From: Yun Wu <wuyun.wu@huawei.com>
To: <marc.zyngier@arm.com>, <tglx@linutronix.de>, <jason@lakedaemon.net>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Yun Wu <wuyun.wu@huawei.com>
Subject: [PATCH v4 3/5] irqchip: gicv3-its: add limitation to page order
Date: Fri, 6 Mar 2015 12:13:21 +0800 [thread overview]
Message-ID: <1425615203-3300-4-git-send-email-wuyun.wu@huawei.com> (raw)
In-Reply-To: <1425615203-3300-1-git-send-email-wuyun.wu@huawei.com>
When required size of Device Table is out of the page allocator's
capability, the whole ITS will fail in probing. This actually is
not the hardware's problem and is mainly a limitation of the kernel
page allocator. This patch will keep ITS going on to the next
initializaion stage with an explicit warning.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Yun Wu <wuyun.wu@huawei.com>
---
drivers/irqchip/irq-gic-v3-its.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index f5bfa42..e8bda0b 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -828,6 +828,11 @@ static int its_alloc_tables(struct its_node *its)
u32 ids = GITS_TYPER_DEVBITS(typer);
order = get_order((1UL << ids) * entry_size);
+ if (order >= MAX_ORDER) {
+ order = MAX_ORDER - 1;
+ pr_warn("%s: Device Table too large, reduce its page order to %u\n",
+ its->msi_chip.of_node->full_name, order);
+ }
}
alloc_size = (1 << order) * PAGE_SIZE;
--
1.8.0
next prev parent reply other threads:[~2015-03-06 4:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 4:13 [PATCH v4 0/5] enhance configuring an ITS Yun Wu
2015-03-06 4:13 ` [PATCH v4 1/5] irqchip: gicv3-its: zero itt before handling to hardware Yun Wu
2015-03-06 4:13 ` [PATCH v4 2/5] irqchip: gicv3-its: use 64KB page as default granule Yun Wu
2015-03-06 16:04 ` Marc Zyngier
2015-03-06 4:13 ` Yun Wu [this message]
2015-03-06 4:13 ` [PATCH v4 4/5] irqchip: gicv3-its: define macros for GITS_CTLR fields Yun Wu
2015-03-06 4:13 ` [PATCH v4 5/5] irqchip: gicv3-its: support safe initialization Yun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425615203-3300-4-git-send-email-wuyun.wu@huawei.com \
--to=wuyun.wu@huawei.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®