From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 2/2] spi: qup: Request CS GPIO's during probe
Date: Fri, 6 Mar 2015 17:26:18 +0200 [thread overview]
Message-ID: <1425655578-22400-2-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1425655578-22400-1-git-send-email-iivanov@mm-sol.com>
Ensure that driver is owner of the GPIO's used for CS signals.
Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
drivers/spi/spi-qup.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 2b2c359..a07ba46 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -14,11 +14,13 @@
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/err.h>
+#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/list.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/spi/spi.h>
@@ -499,7 +501,7 @@ static int spi_qup_probe(struct platform_device *pdev)
struct device *dev;
void __iomem *base;
u32 max_freq, iomode, num_cs;
- int ret, irq, size;
+ int ret, irq, size, cs, cs_gpio;
dev = &pdev->dev;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -556,6 +558,19 @@ static int spi_qup_probe(struct platform_device *pdev)
else
master->num_chipselect = num_cs;
+ for (cs = 0; cs < master->num_chipselect; cs++) {
+ cs_gpio = of_get_named_gpio(dev->of_node, "cs-gpios", cs);
+
+ if (!gpio_is_valid(cs_gpio))
+ continue;
+
+ ret = devm_gpio_request(&pdev->dev, cs_gpio, "spi-qup-cs");
+ if (ret) {
+ dev_err(&pdev->dev, "can't get cs gpios\n");
+ goto error;
+ }
+ }
+
master->bus_num = pdev->id;
master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LOOP;
master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);
--
1.9.1
next prev parent reply other threads:[~2015-03-06 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 15:26 [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Ivan T. Ivanov
2015-03-06 15:26 ` Ivan T. Ivanov [this message]
2015-03-06 18:34 ` [PATCH 2/2] spi: qup: Request CS GPIO's during probe Stephen Boyd
2015-03-09 8:20 ` Ivan T. Ivanov
2015-03-09 18:53 ` Stephen Boyd
2015-03-10 8:31 ` Ivan T. Ivanov
2015-03-17 11:02 ` Ivan T. Ivanov
2015-03-07 10:59 ` Mark Brown
[not found] ` <1425889415.2440.10.camel@mm-sol.com>
[not found] ` <20150309182841.GW28806@sirena.org.uk>
2015-03-10 8:10 ` Ivan T. Ivanov
2015-03-10 11:06 ` Mark Brown
2015-03-10 12:53 ` Ivan T. Ivanov
2015-03-10 20:47 ` Mark Brown
2015-03-07 11:01 ` [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425655578-22400-2-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=broonie@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®