From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756565AbbCFUbY (ORCPT ); Fri, 6 Mar 2015 15:31:24 -0500 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:45817 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755098AbbCFUbX (ORCPT ); Fri, 6 Mar 2015 15:31:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2892:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3872:4250:4321:5007:6261:6742:6743:7974:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12295:12438:12517:12519:12740:13069:13076:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wind83_7fc7b7900cc48 X-Filterd-Recvd-Size: 3155 Message-ID: <1425673876.12017.50.camel@perches.com> Subject: Re: [PATCH v9 01/21] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning From: Joe Perches To: Grant Likely Cc: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Olof Johansson , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , Graeme Gregory , Sudeep Holla , Jon Masters , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , suravee.suthikulpanit@amd.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org Date: Fri, 06 Mar 2015 12:31:16 -0800 In-Reply-To: <20150306201718.9363CC40AA9@trevor.secretlab.ca> References: <1424853601-6675-1-git-send-email-hanjun.guo@linaro.org> <1424853601-6675-2-git-send-email-hanjun.guo@linaro.org> <20150306201718.9363CC40AA9@trevor.secretlab.ca> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-06 at 20:17 +0000, Grant Likely wrote: > On Wed, 25 Feb 2015 16:39:41 +0800 Hanjun Guo wrote: > > This patch just use pr_debug() instead of pr_info() for ioapic/iosapic, > > local apic/x2apic/sapic structures when scanning the MADT table to remove > > those verbose information, but leave other structures unchanged. [] > One nitpick below, but don't respin over this, and don't do a fixup. [] > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c [] > > @@ -61,9 +63,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) > > { > > struct acpi_madt_local_apic *p = > > (struct acpi_madt_local_apic *)header; > > - pr_info("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", > > - p->processor_id, p->id, > > - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); > > + pr_debug("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", > > + p->processor_id, p->id, > > + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); > > The whitespace changes makes each 1 line change into 3 line changes. In > these situations, I would chose to leave the whitespace alone to keep > the diffstat as small as possible. It makes it less likely to conflict > with other patches and easier to find context. I think it's mostly better to use a consistent indentation style regardless of the number in whitespace changes surrounding the change.