From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756318AbbCGBDK (ORCPT ); Fri, 6 Mar 2015 20:03:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39827 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753867AbbCGBDI (ORCPT ); Fri, 6 Mar 2015 20:03:08 -0500 Message-ID: <1425690180.19505.68.camel@stgolabs.net> Subject: Re: [PATCH] kernel/locking/locktorture: fix deadlock in 'rw_lock_irq' type From: Davidlohr Bueso To: paulmck@linux.vnet.ibm.com Cc: Alexey Kodanev , josh@joshtriplett.org, linux-kernel@vger.kernel.org, vasily.isaenko@oracle.com Date: Fri, 06 Mar 2015 17:03:00 -0800 In-Reply-To: <20150307003742.GH5236@linux.vnet.ibm.com> References: <1425686813-24029-1-git-send-email-alexey.kodanev@oracle.com> <20150307003742.GH5236@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-06 at 16:37 -0800, Paul E. McKenney wrote: > On Sat, Mar 07, 2015 at 03:06:53AM +0300, Alexey Kodanev wrote: > > torture_rwlock_read_unlock_irq() must use read_unlock_irqrestore() > > instead of write_unlock_irqrestore(). > > > > Use read_unlock_irqrestore() instead of write_unlock_irqrestore(). > > > > Signed-off-by: Alexey Kodanev > > Good catch! If Davidlohr has no objections, I will queue this one. Dear me, yes that looks completely borken. Thanks for the fix.