From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbbCGMvO (ORCPT ); Sat, 7 Mar 2015 07:51:14 -0500 Received: from cpsmtpb-ews05.kpnxchange.com ([213.75.39.8]:64085 "EHLO cpsmtpb-ews05.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbbCGMvM (ORCPT ); Sat, 7 Mar 2015 07:51:12 -0500 Message-ID: <1425732670.2281.14.camel@tiscali.nl> Subject: Re: [PATCH 2/2] i2c, i2c_imc: Add DIMM bus code From: Paul Bolle To: Andy Lutomirski Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Jean Delvare , Guenter Roeck , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rui Wang , Tony Luck , One Thousand Gnomes , Alun Evans , Robert Elliott , Boaz Harrosh Date: Sat, 07 Mar 2015 13:51:10 +0100 In-Reply-To: <4ec9e7471354b350936ffa75e94125b169d14690.1425695891.git.luto@amacapital.net> References: <4ec9e7471354b350936ffa75e94125b169d14690.1425695891.git.luto@amacapital.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Mar 2015 12:51:10.0377 (UTC) FILETIME=[62DE7990:01D058D5] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just a license nit, I'm afraid. Andy Lutomirski schreef op vr 06-03-2015 om 18:50 [-0800]: > --- /dev/null > +++ b/drivers/i2c/busses/dimm-bus.c > @@ -0,0 +1,97 @@ > +/* > + * Copyright (c) 2013 Andrew Lutomirski > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 > + * as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > + */ This states the license is GPL v2. > +MODULE_LICENSE("GPL"); So you probably want MODULE_LICENSE("GPL v2"); here too. Paul Bolle