From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752104AbbCGNmG (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 08:42:06 -0500
Received: from cpsmtpb-ews02.kpnxchange.com ([213.75.39.5]:49201 "EHLO
	cpsmtpb-ews02.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750728AbbCGNmE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 08:42:04 -0500
Message-ID: <1425735720.2281.18.camel@tiscali.nl>
Subject: Re: [PATCH] drivers: hwspinlock: add CSR atlas7 implementation
From: Paul Bolle <pebolle@tiscali.nl>
To: Barry Song <21cnbao@gmail.com>
Cc: ohad@wizery.com, linux-kernel@vger.kernel.org, workgroup.linux@csr.com,
        Wei Chen <wei.chen@csr.com>, Barry Song <Baohua.Song@csr.com>
Date: Sat, 07 Mar 2015 14:42:00 +0100
In-Reply-To: <1425630613-6123-1-git-send-email-21cnbao@gmail.com>
References: <1425630613-6123-1-git-send-email-21cnbao@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 07 Mar 2015 13:42:01.0370 (UTC) FILETIME=[7D670FA0:01D058DC]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

One license nit.

Barry Song schreef op vr 06-03-2015 om 16:30 [+0800]:
> --- /dev/null
> +++ b/drivers/hwspinlock/sirf_hwspinlock.c
> @@ -0,0 +1,151 @@
> +/*
> + * SIRF hardware spinlock driver
> + *
> + * Copyright (c) 2014 Cambridge Silicon Radio Limited, a CSR plc group company.
> + *
> + * Licensed under GPLv2 or later.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

So you probably want
    MODULE_LICENSE("GPL");

here.


Paul Bolle