From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbbCIGAI (ORCPT ); Mon, 9 Mar 2015 02:00:08 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:45541 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbCIGAF (ORCPT ); Mon, 9 Mar 2015 02:00:05 -0400 From: Yongbae Park To: msink@permonline.ru Cc: davem@davemloft.net, nicolas.ferre@atmel.com, tklauser@distanz.ch, wsa@the-dreams.de, varkabhadram@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH] ibmveth: enable interrupts after napi_complete() Date: Mon, 9 Mar 2015 15:00:59 +0900 Message-Id: <1425880859-17509-1-git-send-email-yongbae2@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The interrupt is enabled before napi_complete(). A network timeout occurs if the interrupt handler is called before napi_complete(). Fix the bug by enabling the interrupt after napi_complete(). Signed-off-by: Yongbae Park --- drivers/net/ethernet/ibm/ibmveth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 21978cc..edcb4c7 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1136,6 +1136,8 @@ restart_poll: ibmveth_replenish_task(adapter); if (frames_processed < budget) { + napi_complete(napi); + /* We think we are done - reenable interrupts, * then check once more to make sure we are done. */ @@ -1144,8 +1146,6 @@ restart_poll: BUG_ON(lpar_rc != H_SUCCESS); - napi_complete(napi); - if (ibmveth_rxq_pending_buffer(adapter) && napi_reschedule(napi)) { lpar_rc = h_vio_signal(adapter->vdev->unit_address, -- 1.9.1