From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754098AbbCIJsf (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 05:48:35 -0400
Received: from metis.ext.pengutronix.de ([92.198.50.35]:49971 "EHLO
	metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753043AbbCIJse (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 05:48:34 -0400
Message-ID: <1425894502.3152.12.camel@pengutronix.de>
Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap
 trace events
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@pengutronix.de, Pankaj Dubey <pankaj.dubey@samsung.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 09 Mar 2015 10:48:22 +0100
In-Reply-To: <20150307105747.GC28806@sirena.org.uk>
References: <1425651415-31590-1-git-send-email-p.zabel@pengutronix.de>
	 <20150307105747.GC28806@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Samstag, den 07.03.2015, 10:57 +0000 schrieb Mark Brown:
> On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:
> 
> >  #include <linux/sort.h>
> > -#include <trace/events/regmap.h>
> >  
> >  #include "internal.h"
> >  
> > +#include <trace/events/regmap.h>
> > +
> 
> The change is basically OK but the above is a bit too funky for my
> taste - it feels like it's asking for annoying compile breakage if
> anyone changes anything. I'd be more inclined to move the header
> somewhere where the events stuff can see it than do this.

Good point. As I see it I have three possiblities now:

a) Just #include "../../../drivers/base/regmap/internal.h" in
   include/trace/events/regmap.h

b) Move drivers/base/regmap/internal.h to
   include/linux/regmap-internal.h and
   #include <linux/regmap-internal.h> in include/trace/events/regmap.h

c) Move include/trace/events/regmap.h to drivers/base/regmap/trace.h
   and just #include "internal.h" in drivers/base/regmap/trace.h

Which, if any, of these options would you prefer? Here is an
unscientific survey:

a) $ git grep "#include \"\.\." include/
   include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/fdt.h"
   include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/libfdt.h"
   include/xen/interface/io/vscsiif.h:#include "../grant_table.h"

b) $ find include/ -name "*internal.h"
   include/linux/timekeeper_internal.h

c) $ find drivers/ -name trace.h
   drivers/net/wireless/ath/ath10k/trace.h
   drivers/net/wireless/ath/trace.h
   drivers/net/wireless/ath/wil6210/trace.h
   drivers/net/wireless/ath/ath5k/trace.h
   drivers/net/wireless/ath/ath6kl/trace.h
   drivers/usb/dwc3/trace.h
   drivers/misc/cxl/trace.h

a) and b) aren't very common, and c) is mostly used by driver-level, not
subsystem-level trace events.

regards
Philipp