From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbbCIOig (ORCPT ); Mon, 9 Mar 2015 10:38:36 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:35207 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206AbbCIOif (ORCPT ); Mon, 9 Mar 2015 10:38:35 -0400 From: Sudip Mukherjee To: Willy Tarreau , Greg Kroah-Hartman Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] staging: panel: register reboot Date: Mon, 9 Mar 2015 20:08:23 +0530 Message-Id: <1425911905-14780-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org we donot need the reboot notifier in module init section, as the notifier is used after lcd is initialized. so lets register for the reboot notifier only after we have successfully attached to the parallel port. and similarly unregister at detach. Signed-off-by: Sudip Mukherjee Acked-by: Willy Tarreau --- v2: same as v1 drivers/staging/panel/panel.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index f329e3f..3ef3dcf 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -2206,6 +2206,7 @@ static void panel_attach(struct parport *port) if (misc_register(&keypad_dev)) goto err_lcd_unreg; } + register_reboot_notifier(&panel_notifier); return; err_lcd_unreg: @@ -2227,6 +2228,8 @@ static void panel_detach(struct parport *port) return; } + unregister_reboot_notifier(&panel_notifier); + if (keypad.enabled && keypad_initialized) { misc_deregister(&keypad_dev); keypad_initialized = 0; @@ -2293,7 +2296,6 @@ static int __init panel_init_module(void) break; } - /* * Overwrite selection with module param values (both keypad and lcd), * where the deprecated params have lower prio. @@ -2363,8 +2365,6 @@ static int __init panel_init_module(void) return -EIO; } - register_reboot_notifier(&panel_notifier); - if (pprt) pr_info("driver version " PANEL_VERSION " registered on parport%d (io=0x%lx).\n", parport, @@ -2380,7 +2380,6 @@ static int __init panel_init_module(void) static void __exit panel_cleanup_module(void) { - unregister_reboot_notifier(&panel_notifier); if (scan_timer.function != NULL) del_timer_sync(&scan_timer); -- 1.8.1.2