From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbbCIOim (ORCPT ); Mon, 9 Mar 2015 10:38:42 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:37041 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754356AbbCIOih (ORCPT ); Mon, 9 Mar 2015 10:38:37 -0400 From: Sudip Mukherjee To: Willy Tarreau , Greg Kroah-Hartman Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] staging: panel: return register value Date: Mon, 9 Mar 2015 20:08:24 +0530 Message-Id: <1425911905-14780-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1425911905-14780-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1425911905-14780-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org we were returning success even if the module failed to register. now we are returning the actual return value, success or error. Signed-off-by: Sudip Mukherjee --- v2: added the error message if parport_register_driver() fails. drivers/staging/panel/panel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 3ef3dcf..65872fa 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -2254,7 +2254,7 @@ static struct parport_driver panel_driver = { /* init function */ static int __init panel_init_module(void) { - int selected_keypad_type = NOT_SET; + int selected_keypad_type = NOT_SET, err; /* take care of an eventual profile */ switch (profile) { @@ -2360,9 +2360,10 @@ static int __init panel_init_module(void) return -ENODEV; } - if (parport_register_driver(&panel_driver)) { + err = parport_register_driver(&panel_driver); + if (err) { pr_err("could not register with parport. Aborting.\n"); - return -EIO; + return err; } if (pprt) -- 1.8.1.2