From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753635AbbCISrT (ORCPT ); Mon, 9 Mar 2015 14:47:19 -0400 Received: from cpsmtpb-ews01.kpnxchange.com ([213.75.39.4]:60501 "EHLO cpsmtpb-ews01.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbbCISrQ (ORCPT ); Mon, 9 Mar 2015 14:47:16 -0400 Message-ID: <1425926832.2317.16.camel@tiscali.nl> Subject: Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver From: Paul Bolle To: Linus Walleij Cc: Ray Jui , Alexandre Courbot , Stephen Warren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Christian Daudt , Matt Porter , Florian Fainelli , Russell King , Arnd Bergmann , Scott Branden , Dmitry Torokhov , Anatol Pomazau , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , bcm-kernel-feedback-list , "devicetree@vger.kernel.org" Date: Mon, 09 Mar 2015 19:47:12 +0100 In-Reply-To: References: <1425515756-321-1-git-send-email-rjui@broadcom.com> <1425515756-321-7-git-send-email-rjui@broadcom.com> <1425543104.24292.185.camel@x220> <1425544581.24292.194.camel@x220> <54F88EB8.3020208@broadcom.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 09 Mar 2015 18:47:12.0817 (UTC) FILETIME=[74B3A210:01D05A99] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Walleij schreef op ma 09-03-2015 om 17:41 [+0100]: > As pointed out in another mail on similar subject, I think these macros > are a kind of obsolete documentation and if they should be dropped we > need to go over an entire subsystem at a time and remove all boolean users > in a big patch. And, as I stated in that other thread, we could start by first checking for things like this during review. (And if people were to do clean up patches I'd suggest to do them one driver at a time. Just to keep things manageable.) Paul Bolle