From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbbCJXgK (ORCPT ); Tue, 10 Mar 2015 19:36:10 -0400 Received: from ozlabs.org ([103.22.144.67]:44320 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbbCJXgI (ORCPT ); Tue, 10 Mar 2015 19:36:08 -0400 Message-ID: <1426030567.20917.3.camel@ellerman.id.au> Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles From: Michael Ellerman To: Shuah Khan Cc: mmarek@suse.cz, linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, linux-api@vger.kernel.org Date: Wed, 11 Mar 2015 10:36:07 +1100 In-Reply-To: <54FE2377.9040709@osg.samsung.com> References: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> <54FDAE28.6050801@osg.samsung.com> <54FE2377.9040709@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-09 at 16:49 -0600, Shuah Khan wrote: > On 03/09/2015 08:28 AM, Shuah Khan wrote: > > On 03/04/2015 03:19 AM, Michael Ellerman wrote: > >> The makefiles under tools/testing/selftests are not real kbuild > >> makefiles, they are regular stand alone makefiles. As such they *do* > >> want all the standard implicit rules and variables defined. > >> > >> So before calling those makefiles, filter -rR out of MAKEFLAGS. > >> > >> Without this not all the selftests are built correctly when called via > >> the top-level Makefile. > >> > >> Signed-off-by: Michael Ellerman > > > > Hi Michal, > > > > Could you please take this patch in your tree. > > > > Acked-by: Shuah Khan > > > > I am changing this to a Nack. This is not fully cooked. > I am seeing new failures on some tests. > > gcc: error: elf_x86_64: No such file or directory > gcc: error: unrecognized command line option ‘-m’ I can't reproduce that here. In what way do you think it's related to this patch? cheers