From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752393AbbCKDPP (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Mar 2015 23:15:15 -0400
Received: from ozlabs.org ([103.22.144.67]:55058 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750785AbbCKDPM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Mar 2015 23:15:12 -0400
Message-ID: <1426043710.23148.1.camel@ellerman.id.au>
Subject: Re: [PATCH 2/9] selftests: Add install target
From: Michael Ellerman <mpe@ellerman.id.au>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com, mmarek@suse.cz,
        linux-api@vger.kernel.org
Date: Wed, 11 Mar 2015 14:15:10 +1100
In-Reply-To: <20150305185326.GA30620@codemonkey.org.uk>
References: <1425358302-16680-1-git-send-email-mpe@ellerman.id.au>
	 <1425358302-16680-2-git-send-email-mpe@ellerman.id.au>
	 <20150305185326.GA30620@codemonkey.org.uk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-03-05 at 13:53 -0500, Dave Jones wrote:
> On Tue, Mar 03, 2015 at 03:51:35PM +1100, Michael Ellerman wrote:
>  > This adds make install support to selftests. The basic usage is:
>  > 
>  > $ cd tools/testing/selftests
>  > $ make install
>  > 
>  > That installs into tools/testing/selftests/install, which can then be
>  > copied where ever necessary.
>  > 
>  > The install destination is also configurable using eg:
>  > 
>  > $ INSTALL_PATH=/mnt/selftests make install
> 
>  ...
> 
>  > +	@# Ask all targets to emit their test scripts
>  > +	echo "#!/bin/bash\n\n" > $(ALL_SCRIPT)
> 
> $ ./all.sh 
> -bash: ./all.sh: /bin/bash\n\n: bad interpreter: No such file or directory
> 
> Removing the \n\n fixes it.
> 
>  > +		echo "cd \$$ROOT\n" >> $(ALL_SCRIPT); \
> 
> ditto

Weird, I don't see that.

  $ make install
  $ head install/run_kselftest.sh
  #!/bin/bash
  
  
  cd $(dirname $0)


Does it depend on the shell? I guess none of the newlines are necessary so I'll
just remove them.

cheers