From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbbCKNbk (ORCPT ); Wed, 11 Mar 2015 09:31:40 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:44164 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbbCKNbV (ORCPT ); Wed, 11 Mar 2015 09:31:21 -0400 From: Matteo Semenzato X-Google-Original-From: Matteo Semenzato To: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, shack@linux.com, vitaly.osipov@gmail.com, peter.senna@gmail.com, vthakkar1994@gmail.com, cengelma@gmx.at, sudipm.mukherjee@gmail.com, tapaswenipathak@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Matteo Semenzato Subject: [PATCH] Staging: rtl8712: fix potential null pointer dereference Date: Wed, 11 Mar 2015 14:31:14 +0100 Message-Id: <1426080674-2075-1-git-send-email-mattew8898@gmail.com> X-Mailer: git-send-email 2.3.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matteo Semenzato Check if kmalloc succeded before using the pointer in memcpy. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c index 977a833..c6e9012 100644 --- a/drivers/staging/rtl8712/rtl871x_mlme.c +++ b/drivers/staging/rtl8712/rtl871x_mlme.c @@ -727,6 +727,8 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf) if (sizeof(struct list_head) == 4 * sizeof(u32)) { pnetwork = kmalloc(sizeof(struct wlan_network), GFP_ATOMIC); + if (!pnetwork) + return; memcpy((u8 *)pnetwork+16, (u8 *)pbuf + 8, sizeof(struct wlan_network) - 16); } else -- 2.3.2