From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbbCKP0T (ORCPT ); Wed, 11 Mar 2015 11:26:19 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:52362 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbbCKP0P (ORCPT ); Wed, 11 Mar 2015 11:26:15 -0400 Message-ID: <1426087526.17007.315.camel@misato.fc.hp.com> Subject: Re: [PATCH 1/3] mm, x86: Document return values of mapping funcs From: Toshi Kani To: Ingo Molnar Cc: "akpm@linux-foundation.org" , "hpa@zytor.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "arnd@arndb.de" , "linux-mm@kvack.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "dave.hansen@intel.com" , "Elliott, Robert (Server Storage)" , "pebolle@tiscali.nl" Date: Wed, 11 Mar 2015 09:25:26 -0600 In-Reply-To: <20150311063024.GB29788@gmail.com> References: <1426018997-12936-1-git-send-email-toshi.kani@hp.com> <1426018997-12936-2-git-send-email-toshi.kani@hp.com> <20150311063024.GB29788@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-11 at 06:30 +0000, Ingo Molnar wrote: > * Toshi Kani wrote: > > > Documented the return values of KVA mapping functions, > > pud_set_huge(), pmd_set_huge, pud_clear_huge() and > > pmd_clear_huge(). > > > > Simplified the conditions to select HAVE_ARCH_HUGE_VMAP > > in Kconfig since X86_PAE depends on X86_32. > > Changelogs are not a diary, they are a story, generally written in the > present tense. Oh, I see. Thanks for the tip! > So it should be something like: > > Document the return values of KVA mapping functions, > pud_set_huge(), pmd_set_huge, pud_clear_huge() and > pmd_clear_huge(). > > Simplify the conditions to select HAVE_ARCH_HUGE_VMAP > in the Kconfig, since X86_PAE depends on X86_32. > > (also note the slight fixes I made to the text.) Updated with the descriptions above. > > There is no functinal change in this patch. > > Typo. Fixed. > > +/** > > + * pud_set_huge - setup kernel PUD mapping > > + * > > + * MTRRs can override PAT memory types with a 4KB granularity. Therefore, > > s/with a/with Fixed. > > + * it does not set up a huge page when the range is covered by non-WB type > > + * of MTRRs. 0xFF indicates that MTRRs are disabled. > > + * > > + * Return 1 on success, and 0 on no-operation. > > What is a 'no-operation'? > > I suspect you want: > > * Returns 1 on success, and 0 when no PUD was set. Yes, that's what it meant to say. > > +/** > > + * pmd_set_huge - setup kernel PMD mapping > > + * > > + * MTRRs can override PAT memory types with a 4KB granularity. Therefore, > > + * it does not set up a huge page when the range is covered by non-WB type > > + * of MTRRs. 0xFF indicates that MTRRs are disabled. > > + * > > + * Return 1 on success, and 0 on no-operation. > > Ditto (and the rest of the patch). Updated all functions. I changed pud_clear_huge()'s description to: * Return 1 on success, and 0 when no PUD map was found. Thanks! -Toshi