From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbbCKVVq (ORCPT ); Wed, 11 Mar 2015 17:21:46 -0400 Received: from smtprelay0219.hostedemail.com ([216.40.44.219]:43781 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751962AbbCKVVn (ORCPT ); Wed, 11 Mar 2015 17:21:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,3,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2504:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:3868:3870:3871:4321:5007:6119:6261:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: honey38_8312c5534634b X-Filterd-Recvd-Size: 2226 Message-ID: <1426108898.32696.67.camel@perches.com> Subject: Re: [PATCH 1/1] Drivers: Staging: ft1000: checkpatch warning fixes From: Joe Perches To: Janakarajan Natarajan Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Marek Belisko , linux-kernel@vger.kernel.org Date: Wed, 11 Mar 2015 14:21:38 -0700 In-Reply-To: <1426107804-54961-1-git-send-email-janakarajann@gmail.com> References: <1426107804-54961-1-git-send-email-janakarajann@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-11 at 14:03 -0700, Janakarajan Natarajan wrote: > Addition of blank line after declaration in ft1000_hw.c > Minor changes to remove {} from single line if and remove extra parenthesis. > Fixes checkpatch warning for and usage. Most prefer separate patches for each type of change, so this single patch could be 3 patches. > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c and for more trivia: > @@ -1948,11 +1948,11 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id) > ft1000_read_reg(dev, > FT1000_REG_MAG_DFSR); > } > - if (tempword & 0x1f) { > + if (tempword & 0x1f) > ft1000_copy_up_pkt(dev); > - } else { > + else > break; > - } > + > cnt++; > } while (cnt < MAX_RCV_LOOP); do { if (foo) bar; else break; } while (baz); is generally better written do { if (!foo) break; bar; } while (baz); so if (!(tempword & 0x1f)) break; ft100_copy_up_pkt(dev); cnt++; } while (cnt < MAX_RCV_LOOP); or maybe if (!(tempword & 0x1f)) break; ft100_copy_up_pkt(dev); } while (++cnt < MAX_RCV_LOOP);