From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbbCLD3N (ORCPT ); Wed, 11 Mar 2015 23:29:13 -0400 Received: from mail-bn1on0139.outbound.protection.outlook.com ([157.56.110.139]:60240 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751262AbbCLD3J (ORCPT ); Wed, 11 Mar 2015 23:29:09 -0400 From: Scott Wood To: , CC: Scott Wood , Michal Simek Subject: [PATCH 10/22] microblaze: %pF is only for function pointers Date: Wed, 11 Mar 2015 22:13:45 -0500 Message-ID: <1426130037-17956-10-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426130037-17956-1-git-send-email-scottwood@freescale.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BN1PR08CA0019.namprd08.prod.outlook.com (10.242.217.147) To BY2PR0301MB0726.namprd03.prod.outlook.com (25.160.63.16) Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(122386002)(92566002)(62966003)(40100003)(19580395003)(19580405001)(77156002)(46102003)(50226001)(42186005)(2950100001)(50986999)(87976001)(86362001)(47776003)(50466002)(229853001)(36756003)(66066001)(48376002)(33646002)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0726;H:snotra.am.freescale.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:BY2PR0301MB0726;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 03:14:36.0378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood Cc: Michal Simek --- arch/microblaze/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/mm/pgtable.c b/arch/microblaze/mm/pgtable.c index 4f4520e..8a8f1cd 100644 --- a/arch/microblaze/mm/pgtable.c +++ b/arch/microblaze/mm/pgtable.c @@ -74,7 +74,7 @@ static void __iomem *__ioremap(phys_addr_t addr, unsigned long size, p >= memory_start && p < virt_to_phys(high_memory) && !(p >= __virt_to_phys((phys_addr_t)__bss_stop) && p < __virt_to_phys((phys_addr_t)__bss_stop))) { - pr_warn("__ioremap(): phys addr "PTE_FMT" is RAM lr %pf\n", + pr_warn("__ioremap(): phys addr "PTE_FMT" is RAM lr %ps\n", (unsigned long)p, __builtin_return_address(0)); return NULL; } -- 2.1.0