From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbbCLD3W (ORCPT ); Wed, 11 Mar 2015 23:29:22 -0400 Received: from mail-bn1bn0105.outbound.protection.outlook.com ([157.56.110.105]:35200 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751262AbbCLD3T (ORCPT ); Wed, 11 Mar 2015 23:29:19 -0400 From: Scott Wood To: , CC: Scott Wood , , Subject: [PATCH 13/22] x86: %pF is only for function pointers Date: Wed, 11 Mar 2015 22:13:48 -0500 Message-ID: <1426130037-17956-13-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426130037-17956-1-git-send-email-scottwood@freescale.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BN1PR08CA0019.namprd08.prod.outlook.com (10.242.217.147) To BY2PR0301MB0726.namprd03.prod.outlook.com (25.160.63.16) Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(122386002)(92566002)(62966003)(40100003)(19580395003)(19580405001)(77156002)(46102003)(50226001)(42186005)(2950100001)(50986999)(87976001)(86362001)(47776003)(50466002)(229853001)(36756003)(66066001)(48376002)(33646002)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0726;H:snotra.am.freescale.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:BY2PR0301MB0726;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 03:14:41.2410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood Cc: x86@kernel.org Cc: xen-devel@lists.xenproject.org --- arch/x86/include/asm/trace/exceptions.h | 2 +- arch/x86/xen/multicalls.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/trace/exceptions.h b/arch/x86/include/asm/trace/exceptions.h index 2fbc66c..e04d75b 100644 --- a/arch/x86/include/asm/trace/exceptions.h +++ b/arch/x86/include/asm/trace/exceptions.h @@ -28,7 +28,7 @@ DECLARE_EVENT_CLASS(x86_exceptions, __entry->error_code = error_code; ), - TP_printk("address=%pf ip=%pf error_code=0x%lx", + TP_printk("address=%ps ip=%ps error_code=0x%lx", (void *)__entry->address, (void *)__entry->ip, __entry->error_code) ); diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c index ea54a08..13598f9 100644 --- a/arch/x86/xen/multicalls.c +++ b/arch/x86/xen/multicalls.c @@ -103,7 +103,7 @@ void xen_mc_flush(void) ret, smp_processor_id()); dump_stack(); for (i = 0; i < b->mcidx; i++) { - printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n", + printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pS\n", i+1, b->mcidx, b->debug[i].op, b->debug[i].args[0], -- 2.1.0