From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbCLF1V (ORCPT ); Thu, 12 Mar 2015 01:27:21 -0400 Received: from mail-by2on0103.outbound.protection.outlook.com ([207.46.100.103]:33600 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750909AbbCLF1S (ORCPT ); Thu, 12 Mar 2015 01:27:18 -0400 X-Greylist: delayed 7990 seconds by postgrey-1.27 at vger.kernel.org; Thu, 12 Mar 2015 01:27:18 EDT Message-ID: <1426138027.30327.109.camel@freescale.com> Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers From: Scott Wood To: CC: , , Date: Thu, 12 Mar 2015 00:27:07 -0500 In-Reply-To: <20150312044532.GB29718@saruman.tx.rr.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-18-git-send-email-scottwood@freescale.com> <20150312044532.GB29718@saruman.tx.rr.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BN3PR09CA0035.namprd09.prod.outlook.com (25.160.111.173) To BY2PR0301MB0725.namprd03.prod.outlook.com (25.160.63.155) Authentication-Results: ti.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0725; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(51704005)(77156002)(86362001)(33646002)(122386002)(92566002)(47776003)(2950100001)(40100003)(62966003)(5820100001)(50466002)(76176999)(110136001)(103116003)(2351001)(50986999)(46102003)(36756003)(42186005)(87976001)(23676002)(50226001)(19580395003)(19580405001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0725;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:BY2PR0301MB0725;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0725; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 05:27:15.8179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0725 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-11 at 23:45 -0500, Felipe Balbi wrote: > On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. > > > > Signed-off-by: Scott Wood > > Cc: linux-usb@vger.kernel.org > > Cc: Felipe Balbi > > --- > > drivers/usb/gadget/function/u_serial.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c > > index 491082a..89179ab 100644 > > --- a/drivers/usb/gadget/function/u_serial.c > > +++ b/drivers/usb/gadget/function/u_serial.c > > @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch) > > unsigned long flags; > > int status; > > > > - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n", > > + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n", > ^ > S ?? %ps is the non-function-pointer version of %pf. %pS is the non-function-pointer version of %pF. I didn't change the capitalization of any of these -- if that's warranted in some places, it's outside the scope of this treewide patchset. -Scott