From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753791AbbCLKYs (ORCPT ); Thu, 12 Mar 2015 06:24:48 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:33495 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621AbbCLKYo (ORCPT ); Thu, 12 Mar 2015 06:24:44 -0400 Message-ID: <1426155872.14455.21.camel@pengutronix.de> Subject: Re: [PATCH v4 03/15] drm: rockchip/dw_hdmi_rockchip: add resume/suspend support From: Philipp Zabel To: Yakir Yang Cc: djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Date: Thu, 12 Mar 2015 11:24:32 +0100 In-Reply-To: <1425177128-1844-1-git-send-email-ykk@rock-chips.com> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425177128-1844-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, den 28.02.2015, 21:32 -0500 schrieb Yakir Yang: > Signed-off-by: Yakir Yang > --- > Changes in v4: None > Changes in v3: > - Setting the .pm member instead of suspend/resume > > Changes in v2: > - Add suspend/resume support for dw_hdmi_rockchip driver > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index d236faa..fc1d02e 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -323,11 +323,27 @@ static int dw_hdmi_rockchip_remove(struct platform_device *pdev) > return 0; > } > > +static int dw_hdmi_rockchip_suspend(struct device *dev) > +{ > + return dw_hdmi_suspend(dev); > +} > + > +static int dw_hdmi_rockchip_resume(struct device *dev) > +{ > + return dw_hdmi_resume(dev); > +} You could just skip dw_hdmi_rockchip_suspend/resume and set .suspend/.resume in dw_hdmi_rockchip_pm directly to dw_hdmi_suspend/resume. > +static const struct dev_pm_ops dw_hdmi_rockchip_pm = { > + .resume = dw_hdmi_rockchip_resume, > + .suspend = dw_hdmi_rockchip_suspend, > +}; > + > static struct platform_driver dw_hdmi_rockchip_pltfm_driver = { > .probe = dw_hdmi_rockchip_probe, > .remove = dw_hdmi_rockchip_remove, > .driver = { > .name = "dwhdmi-rockchip", > + .pm = &dw_hdmi_rockchip_pm, > .of_match_table = dw_hdmi_rockchip_dt_ids, > }, > }; regards Philipp