From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbbCLOOk (ORCPT ); Thu, 12 Mar 2015 10:14:40 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:42331 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754061AbbCLOOh (ORCPT ); Thu, 12 Mar 2015 10:14:37 -0400 From: Sudip Mukherjee To: Benjamin Romer , David Kershner , Greg Kroah-Hartman Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 2/2] staging: unisys: remove comparison Date: Thu, 12 Mar 2015 19:44:21 +0530 Message-Id: <1426169661-15142-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1426169661-15142-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1426169661-15142-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org the macro comparison is always true as MAJOR is defined as unsiged int. Signed-off-by: Sudip Mukherjee --- drivers/staging/unisys/visorchipset/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c index 9ca7f1e..a1e8e79 100644 --- a/drivers/staging/unisys/visorchipset/file.c +++ b/drivers/staging/unisys/visorchipset/file.c @@ -82,10 +82,8 @@ visorchipset_file_cleanup(void) cdev_del(&file_cdev); file_cdev.ops = NULL; if (registered) { - if (MAJOR(majordev) >= 0) { - unregister_chrdev_region(majordev, 1); - majordev = MKDEV(0, 0); - } + unregister_chrdev_region(majordev, 1); + majordev = MKDEV(0, 0); registered = FALSE; } } -- 1.8.1.2