From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754526AbbCLOlY (ORCPT ); Thu, 12 Mar 2015 10:41:24 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56507 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754037AbbCLOlX (ORCPT ); Thu, 12 Mar 2015 10:41:23 -0400 Message-ID: <1426171263.14455.58.camel@pengutronix.de> Subject: Re: [PATCH v4 02/15] drm: bridge/dw_hdmi: wrap irq control in fucntions From: Philipp Zabel To: yakir Cc: djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Date: Thu, 12 Mar 2015 15:41:03 +0100 In-Reply-To: <5501A34A.6050105@rock-chips.com> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425176927-1784-1-git-send-email-ykk@rock-chips.com> <1426155862.14455.19.camel@pengutronix.de> <5501A34A.6050105@rock-chips.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yakir, Am Donnerstag, den 12.03.2015, 22:31 +0800 schrieb yakir: > Hi Philipp, > > On 2015年03月12日 18:24, Philipp Zabel wrote: > > Hi Yakir, > > > > Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang: > >> Wrap irq control in functions, and then we can call in > >> dw_hdmi_bind/dw_hdmi_unbind/dw_hdmi_resume/dw_hdmi_suspend > >> functions. > >> > >> Signed-off-by: Yakir Yang > > [...] > Sorry, I can not understand this comment. could you please talk more > detail about this one. > > Thank you very much :) I use "[...]" as a sign that I removed parts from the quoted email, like this: [...] > > Here you remove code added in the previous patch. > > It would be better to just apply patch 2 first and then rebase patch 1 > > on top of it. > > Thanks, I will reorder patch 1 & patch 2, in next vesion :) regards Philipp