From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030196AbbCLPqE (ORCPT ); Thu, 12 Mar 2015 11:46:04 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:62117 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932381AbbCLPpr (ORCPT ); Thu, 12 Mar 2015 11:45:47 -0400 X-AuditID: cbfee61a-f79c06d000004e71-8b-5501b4a90455 From: Jacek Anaszewski To: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Jacek Anaszewski Subject: [PATCH/RFC v13 01/13] leds: flash: Fix the size of sysfs_groups array Date: Thu, 12 Mar 2015 16:45:02 +0100 Message-id: <1426175114-14876-2-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> References: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDLMWRmVeSWpSXmKPExsVy+t9jQd2VWxhDDf4/Y7c4unMik8X8I+dY LXqvPme0ONv0ht3i8q45bBZb36xjtOjZsJXV4u6po2wWu3c9ZbU4/Kad1eLM/pVsDtweO2fd Zfc4/HUhi8ee+T9YPfq2rGL0WLH6O7vH501yAWxRXDYpqTmZZalF+nYJXBndi84yFzzjqXj9 oLyB8QVXFyMnh4SAicSGh7dYIWwxiQv31rN1MXJxCAlMZ5R4+7eXEcJpZ5J4+ruLDaSKTcBQ 4ueL10wgtohAucSeO4/ZQYqYBTYwSlye0MgCkhAW8JPo/f4ebCyLgKrEtM3zwGxeAQ+JZbe+ AE3lAFqnIDFnkg1ImFPAU6L7/gdGEFsIqGTyhr/sExh5FzAyrGIUTS1ILihOSs811CtOzC0u zUvXS87P3cQIDsNnUjsYVzZYHGIU4GBU4uGt+MoQKsSaWFZcmXuIUYKDWUmE13Q+Y6gQb0pi ZVVqUX58UWlOavEhRmkOFiVxXiX7thAhgfTEktTs1NSC1CKYLBMHp1QDo/Gc1I3y4bnbLqZ/ kmdbdlVotgxn4+GV2o+1PQIc/ywVWnxh+W1egYYzzw5OlNo158Uy/Q0vr77v9lm81snU/87B O/q/jzCfvrCvhnWP3wV2n6m/JqhqRn0q9S7e3DnrzX3rldFSSzosVB6dLVVhKNh7QSGi7m9K wY2KkhlPtpwSEOYqa79QEKzEUpyRaKjFXFScCACfPyoqPwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LED_FLASH_MAX_SYSFS_GROUPS macro had value that was relevant for previous version of the patches introducing LED Flash class. Currently it is required to reserve the room for maximum 4 sysfs groups. Since the last element of the struct attribute_group array passed to the function device_create_with_groups has to be NULL, the size of the array has to be greater by one than maximum allowed number of groups. Therefore, the name of the macro is being changed to LED_FLASH_SYSFS_GROUPS_SIZE, to make it more accurrate. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- include/linux/led-class-flash.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h index 21ec91e..e97966d 100644 --- a/include/linux/led-class-flash.h +++ b/include/linux/led-class-flash.h @@ -32,7 +32,7 @@ struct led_classdev_flash; #define LED_FAULT_LED_OVER_TEMPERATURE (1 << 8) #define LED_NUM_FLASH_FAULTS 9 -#define LED_FLASH_MAX_SYSFS_GROUPS 7 +#define LED_FLASH_SYSFS_GROUPS_SIZE 5 struct led_flash_ops { /* set flash brightness */ @@ -80,7 +80,7 @@ struct led_classdev_flash { struct led_flash_setting timeout; /* LED Flash class sysfs groups */ - const struct attribute_group *sysfs_groups[LED_FLASH_MAX_SYSFS_GROUPS]; + const struct attribute_group *sysfs_groups[LED_FLASH_SYSFS_GROUPS_SIZE]; }; static inline struct led_classdev_flash *lcdev_to_flcdev( -- 1.7.9.5