From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030400AbbCLQOr (ORCPT ); Thu, 12 Mar 2015 12:14:47 -0400 Received: from mail-bn1bon0136.outbound.protection.outlook.com ([157.56.111.136]:25082 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030299AbbCLQOp (ORCPT ); Thu, 12 Mar 2015 12:14:45 -0400 Message-ID: <1426176869.30327.113.camel@freescale.com> Subject: Re: [PATCH 14/22] parisc: %pF is only for function pointers From: Scott Wood To: James Bottomley CC: , , Date: Thu, 12 Mar 2015 11:14:29 -0500 In-Reply-To: <1426162282.2146.77.camel@HansenPartnership.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-14-git-send-email-scottwood@freescale.com> <1426162282.2146.77.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BN3PR09CA0029.namprd09.prod.outlook.com (25.160.111.167) To CY1PR0301MB0731.namprd03.prod.outlook.com (25.160.159.149) Authentication-Results: HansenPartnership.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0731; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(51704005)(377424004)(87976001)(2950100001)(33646002)(50226001)(103116003)(122386002)(110136001)(5820100001)(36756003)(23676002)(40100003)(46102003)(77156002)(47776003)(62966003)(92566002)(50986999)(76176999)(86362001)(50466002)(42186005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB0731;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:CY1PR0301MB0731;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0731; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 16:14:38.0047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0731 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: > On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. Even on > > other architectures, refrain from setting a bad example that people > > copy. > > Are you sure about this? Parisc64 is a function description > architecture. There may be a misunderstanding about what > __builtin_return_address(0) is supposed to return, but I'm certain the > person who added the code thought it returned a function pointer, which > on parisc64 would be a descriptor. I wasn't aware that parisc64 used descriptors, but I don't see how you'd get one out of __builtin_return_address(0) since it's not usually a function entry point (plus, GCC documents it as returning void *). -Scott