From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932540AbbCLQoU (ORCPT ); Thu, 12 Mar 2015 12:44:20 -0400 Received: from mail-bn1on0138.outbound.protection.outlook.com ([157.56.110.138]:59776 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030240AbbCLQn7 (ORCPT ); Thu, 12 Mar 2015 12:43:59 -0400 X-Greylist: delayed 47675 seconds by postgrey-1.27 at vger.kernel.org; Thu, 12 Mar 2015 12:43:58 EDT Message-ID: <1426178623.30327.120.camel@freescale.com> Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers From: Scott Wood To: Sergei Shtylyov CC: , , , Felipe Balbi Date: Thu, 12 Mar 2015 11:43:43 -0500 In-Reply-To: <55018855.9090301@cogentembedded.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-18-git-send-email-scottwood@freescale.com> <55018855.9090301@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BN3PR09CA0011.namprd09.prod.outlook.com (25.160.111.149) To DM2PR0301MB0734.namprd03.prod.outlook.com (25.160.97.142) Authentication-Results: cogentembedded.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0734; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(479174004)(24454002)(377424004)(377454003)(87976001)(103116003)(110136001)(47776003)(46102003)(77156002)(5820100001)(50466002)(36756003)(62966003)(92566002)(2950100001)(15975445007)(33646002)(50986999)(40100003)(23676002)(86362001)(122386002)(76176999)(19580395003)(42186005)(50226001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0734;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:DM2PR0301MB0734;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0734; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 16:43:50.9126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0734 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-12 at 15:36 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/12/2015 6:13 AM, Scott Wood wrote: > > > Use %pS for actual addresses, otherwise you'll get bad output > > %pS or %ps? > > > on arches like ppc64 where %pF expects a function descriptor. > > %pF or %pf? And what is a function descriptor? %pS where %pF appeared, and %ps where %pf appeared (yes, I'll fix the copy-and-paste commit message). A function descriptor is a data structure used when a function pointer needs to contain more information than the instruction pointer to branch to, such as a TOC pointer. Example: http://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi-1.9.html#FUNC-DES -Scott