From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756216AbbCLVqx (ORCPT ); Thu, 12 Mar 2015 17:46:53 -0400 Received: from mail-by2on0132.outbound.protection.outlook.com ([207.46.100.132]:53282 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755875AbbCLVqN (ORCPT ); Thu, 12 Mar 2015 17:46:13 -0400 From: Scott Wood To: , CC: Scott Wood , , James Bottomley Subject: [PATCH v2 14/22] parisc: %pf is only for function pointers Date: Thu, 12 Mar 2015 16:46:00 -0500 Message-ID: <1426196761-4891-2-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426196761-4891-1-git-send-email-scottwood@freescale.com> References: <1426196761-4891-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BN1PR02CA0020.namprd02.prod.outlook.com (10.141.56.20) To DM2PR0301MB0733.namprd03.prod.outlook.com (25.160.97.141) Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0733; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(2950100001)(92566002)(76176999)(50986999)(47776003)(66066001)(50226001)(77156002)(62966003)(33646002)(36756003)(229853001)(122386002)(46102003)(86362001)(87976001)(40100003)(42186005)(19580405001)(19580395003)(48376002)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0733;H:snotra.am.freescale.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:DM2PR0301MB0733;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0733; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 21:46:11.2274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0733 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use %ps for actual addresses, otherwise you'll get bad output on arches like parisc64 where %pf expects a function descriptor. This wasn't normally seen on parisc64 because the code is not built unless DEBUG_SUPERIO_INIT is manually defined. Signed-off-by: Scott Wood Cc: linux-parisc@vger.kernel.org cc: James Bottomley --- v2: Commit message updates drivers/parisc/superio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c index 8be2096..38c5440 100644 --- a/drivers/parisc/superio.c +++ b/drivers/parisc/superio.c @@ -348,7 +348,7 @@ int superio_fixup_irq(struct pci_dev *pcidev) BUG(); return -1; } - printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %pf\n", + printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %ps\n", pci_name(pcidev), pcidev->vendor, pcidev->device, __builtin_return_address(0)); -- 2.1.0