From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756163AbbCLVqT (ORCPT ); Thu, 12 Mar 2015 17:46:19 -0400 Received: from mail-by2on0146.outbound.protection.outlook.com ([207.46.100.146]:37792 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756108AbbCLVqQ (ORCPT ); Thu, 12 Mar 2015 17:46:16 -0400 From: Scott Wood To: , CC: Scott Wood , , "Felipe Balbi" , Fabio Estevam , Sergei Shtylyov Subject: [PATCH v2 18/22] usb: gadget: serial: %pf is only for function pointers Date: Thu, 12 Mar 2015 16:46:01 -0500 Message-ID: <1426196761-4891-3-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426196761-4891-1-git-send-email-scottwood@freescale.com> References: <1426196761-4891-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BN1PR02CA0020.namprd02.prod.outlook.com (10.141.56.20) To DM2PR0301MB0733.namprd03.prod.outlook.com (25.160.97.141) Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0733; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(979002)(6009001)(2950100001)(92566002)(76176999)(50986999)(47776003)(66066001)(50226001)(77156002)(62966003)(33646002)(36756003)(229853001)(122386002)(46102003)(86362001)(87976001)(40100003)(42186005)(19580405001)(19580395003)(48376002)(50466002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0733;H:snotra.am.freescale.net;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002009)(5005006);SRVR:DM2PR0301MB0733;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0733; X-Forefront-PRVS: 05134F8B4F X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 21:46:12.9306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0733 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use %ps for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pf expects a function descriptor (which is not what __builtin_return_address returns). Signed-off-by: Scott Wood Cc: linux-usb@vger.kernel.org Cc: Felipe Balbi Cc: Fabio Estevam CC: Sergei Shtylyov --- v2: Fix commit message to reflect that this patch is about %pf, not %pF, and to clarify (as requested) that __builtin_return_address does not return a function pointer. drivers/usb/gadget/function/u_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 491082a..89179ab 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch) unsigned long flags; int status; - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n", + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n", port->port_num, tty, ch, __builtin_return_address(0)); spin_lock_irqsave(&port->port_lock, flags); -- 2.1.0