From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbbCMOQF (ORCPT ); Fri, 13 Mar 2015 10:16:05 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36173 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbbCMOQB (ORCPT ); Fri, 13 Mar 2015 10:16:01 -0400 From: Ameen Ali To: grundler@parisc-linux.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ameen Ali Subject: [PATCH 9/9] tulip_core.c : out-of-bounds check. Date: Fri, 13 Mar 2015 16:15:52 +0200 Message-Id: <1426256152-5522-1-git-send-email-ameenali023@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Array index 'j' is used before limits check. Suggest put limit check before index use. Signed-off-by : --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c index 3b42556..ed41559 100644 --- a/drivers/net/ethernet/dec/tulip/tulip_core.c +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c @@ -589,7 +589,7 @@ static void tulip_tx_timeout(struct net_device *dev) (unsigned int)tp->rx_ring[i].buffer1, (unsigned int)tp->rx_ring[i].buffer2, buf[0], buf[1], buf[2]); - for (j = 0; buf[j] != 0xee && j < 1600; j++) + for (j = 0; ((j < 1600) && buf[j] != 0xee); j++) if (j < 100) pr_cont(" %02x", buf[j]); pr_cont(" j=%d\n", j); -- 2.1.0