From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756500AbbCMReK (ORCPT ); Fri, 13 Mar 2015 13:34:10 -0400 Received: from mx02.posteo.de ([89.146.194.165]:44018 "EHLO mx02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756299AbbCMReI (ORCPT ); Fri, 13 Mar 2015 13:34:08 -0400 From: Martin Kepplinger To: stefanr@s5r6.in-berlin.de Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH] [RFC] firewire: nosy: simplify grabbing context pointer in open() Date: Fri, 13 Mar 2015 18:33:40 +0100 Message-Id: <1426268020-5923-1-git-send-email-martink@posteo.de> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Martin Kepplinger --- This is a question: What's the real difference between the two solutions? I'm not sure if they are equivalent :( drivers/firewire/nosy.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c index 76b2d39..f43619e 100644 --- a/drivers/firewire/nosy.c +++ b/drivers/firewire/nosy.c @@ -275,16 +275,12 @@ set_phy_reg(struct pcilynx *lynx, int addr, int val) static int nosy_open(struct inode *inode, struct file *file) { - int minor = iminor(inode); struct client *client; - struct pcilynx *tmp, *lynx = NULL; + struct pcilynx *lynx = NULL; mutex_lock(&card_mutex); - list_for_each_entry(tmp, &card_list, link) - if (tmp->misc.minor == minor) { - lynx = lynx_get(tmp); - break; - } + lynx = container_of(file->private_data, struct pcilynx, misc); + lynx = lynx_get(lynx); mutex_unlock(&card_mutex); if (lynx == NULL) return -ENODEV; -- 2.1.4