From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756759AbbCMST3 (ORCPT ); Fri, 13 Mar 2015 14:19:29 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:46545 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756568AbbCMST0 (ORCPT ); Fri, 13 Mar 2015 14:19:26 -0400 From: Alexander Kuleshov To: Peter Zijlstra , Paul Mackerras , Ingo Molnar , linux-kernel@vger.kernel.org Cc: Alexander Kuleshov Subject: [PATCH] perf/builtin-diff: remove unnecessary error output Date: Sat, 14 Mar 2015 00:19:14 +0600 Message-Id: <1426270754-11767-1-git-send-email-kuleshovmail@gmail.com> X-Mailer: git-send-email 2.3.1.291.g7a9409c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch prevents duplicated error output. per_session__new function calls perf_data_file__open which will print error message if it can not open the file and we will get duplicated output of the error message: failed to open perf.data.old: No such file or directory Failed to open perf.data.old Signed-off-by: Alexander Kuleshov --- tools/perf/builtin-diff.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 74aada5..a18bf98 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -742,7 +742,6 @@ static int __cmd_diff(void) data__for_each_file(i, d) { d->session = perf_session__new(&d->file, false, &tool); if (!d->session) { - pr_err("Failed to open %s\n", d->file.path); ret = -1; goto out_delete; } -- 2.3.1.291.g7a9409c