From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbbCOKl6 (ORCPT ); Sun, 15 Mar 2015 06:41:58 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:32828 "EHLO albert.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbbCOKl4 (ORCPT ); Sun, 15 Mar 2015 06:41:56 -0400 From: Geert Uytterhoeven To: Bryan Wu , Richard Purdie Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] leds: pca963x: Add missing initialiation of struct led_info.flags Date: Sun, 15 Mar 2015 11:41:52 +0100 Message-Id: <1426416112-27477-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/leds/leds-pca963x.c: In function ‘pca963x_dt_init’: drivers/leds/leds-pca963x.c:303: warning: ‘led.flags’ is used uninitialized in this function Only the name and default_trigger fields are initialized. Other fields (currently flags only) contain random stack data. Pre-initialize the led structure completely to fix this. Signed-off-by: Geert Uytterhoeven --- drivers/leds/leds-pca963x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c index f110b4c456baa77f..bee3e1ab27fd92fd 100644 --- a/drivers/leds/leds-pca963x.c +++ b/drivers/leds/leds-pca963x.c @@ -289,7 +289,7 @@ pca963x_dt_init(struct i2c_client *client, struct pca963x_chipdef *chip) return ERR_PTR(-ENOMEM); for_each_child_of_node(np, child) { - struct led_info led; + struct led_info led = {}; u32 reg; int res; -- 1.9.1