From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934307AbbCPPZZ (ORCPT ); Mon, 16 Mar 2015 11:25:25 -0400 Received: from www.osadl.org ([62.245.132.105]:59257 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbbCPPZW (ORCPT ); Mon, 16 Mar 2015 11:25:22 -0400 From: Nicholas Mc Guire To: Samuel Ortiz Cc: Lee Jones , linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] mfd: dln2: use msecs_to_jiffies for time conversion Date: Mon, 16 Mar 2015 11:20:49 -0400 Message-Id: <1426519249-14009-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Converting milliseconds to jiffies by "val * HZ / 1000" is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is a minor API consolidation only and should make things more readable. Signed-off-by: Nicholas Mc Guire --- Patch was compile tested with x86_64_defconfig + CONFIG_MFD_DLN2=m Patch is agianst 4.0-rc3 (localversion-next is -next-20150316) drivers/mfd/dln2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index 1be9bd1..704e189 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -435,7 +435,7 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, struct dln2_response *rsp; struct dln2_rx_context *rxc; struct device *dev = &dln2->interface->dev; - const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000; + const unsigned long timeout = msecs_to_jiffies(DLN2_USB_TIMEOUT); struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle]; int size; -- 1.7.10.4