From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH v2 tip/core/rcu 5/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in tiny_plugin.h
Date: Mon, 16 Mar 2015 11:42:20 -0700 [thread overview]
Message-ID: <1426531344-24822-5-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1426531344-24822-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
This commit moves kernel/rcu/tiny_plugin.h from the old ACCESS_ONCE()
API to the new READ_ONCE() and WRITE_ONCE() APIs.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/rcu/tiny_plugin.h | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/kernel/rcu/tiny_plugin.h b/kernel/rcu/tiny_plugin.h
index f94e209a10d6..e492a5253e0f 100644
--- a/kernel/rcu/tiny_plugin.h
+++ b/kernel/rcu/tiny_plugin.h
@@ -144,16 +144,17 @@ static void check_cpu_stall(struct rcu_ctrlblk *rcp)
return;
rcp->ticks_this_gp++;
j = jiffies;
- js = ACCESS_ONCE(rcp->jiffies_stall);
+ js = READ_ONCE(rcp->jiffies_stall);
if (rcp->rcucblist && ULONG_CMP_GE(j, js)) {
pr_err("INFO: %s stall on CPU (%lu ticks this GP) idle=%llx (t=%lu jiffies q=%ld)\n",
rcp->name, rcp->ticks_this_gp, DYNTICK_TASK_EXIT_IDLE,
jiffies - rcp->gp_start, rcp->qlen);
dump_stack();
- ACCESS_ONCE(rcp->jiffies_stall) = jiffies +
- 3 * rcu_jiffies_till_stall_check() + 3;
+ WRITE_ONCE(rcp->jiffies_stall,
+ jiffies + 3 * rcu_jiffies_till_stall_check() + 3);
} else if (ULONG_CMP_GE(j, js)) {
- ACCESS_ONCE(rcp->jiffies_stall) = jiffies + rcu_jiffies_till_stall_check();
+ WRITE_ONCE(rcp->jiffies_stall,
+ jiffies + rcu_jiffies_till_stall_check());
}
}
@@ -161,7 +162,8 @@ static void reset_cpu_stall_ticks(struct rcu_ctrlblk *rcp)
{
rcp->ticks_this_gp = 0;
rcp->gp_start = jiffies;
- ACCESS_ONCE(rcp->jiffies_stall) = jiffies + rcu_jiffies_till_stall_check();
+ WRITE_ONCE(rcp->jiffies_stall,
+ jiffies + rcu_jiffies_till_stall_check());
}
static void check_cpu_stalls(void)
--
1.8.1.5
next prev parent reply other threads:[~2015-03-16 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 18:41 [PATCH tip/core/rcu 0/9] Stop using ACCESS_ONCE (for v4.2) Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 1/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in rculist.h Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 2/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in rcupdate.h Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 3/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in rcutorture.c Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 4/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in srcu.c Paul E. McKenney
2015-03-16 18:42 ` Paul E. McKenney [this message]
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 6/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in tree.c Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 7/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in tree_plugin.h Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 8/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in tree_trace.c Paul E. McKenney
2015-03-16 18:42 ` [PATCH v2 tip/core/rcu 9/9] Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE() in update.c Paul E. McKenney
2015-03-23 14:49 ` [PATCH tip/core/rcu 0/9] Stop using ACCESS_ONCE (for v4.2) Steven Rostedt
2015-03-23 15:25 ` Paul E. McKenney
2015-03-23 15:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426531344-24822-5-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®