From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932259AbbCPWYa (ORCPT ); Mon, 16 Mar 2015 18:24:30 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:33878 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbbCPWY3 (ORCPT ); Mon, 16 Mar 2015 18:24:29 -0400 Message-ID: <1426544667.11398.231.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH] inet: Clean up inet_csk_wait_for_connect() vs. might_sleep() From: Eric Dumazet To: David Miller Cc: peterz@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 16 Mar 2015 15:24:27 -0700 In-Reply-To: <20150316.171243.1969465707208233939.davem@davemloft.net> References: <1426533564.11398.229.camel@edumazet-glaptop2.roam.corp.google.com> <20150316.171243.1969465707208233939.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-16 at 17:12 -0400, David Miller wrote: > From: Eric Dumazet > Date: Mon, 16 Mar 2015 12:19:24 -0700 > > > In commit 26cabd31259ba43f68026ce3f62b78094124333f > > Peter added a sched_annotate_sleep() in sk_wait_event() > > > > Is the following patch needed as well ? > > Who is asking this question and who is it directed at? > > It looks like something that needs to be resolved before I apply this > patch, right? I was asking the question to Peter ;) It's a patch that should enter one of your tree, but I would like a comment from Peter or anyone fully understanding the issue.