From: Wang Long <long.wanglong@huawei.com>
To: <anton@enomsg.org>, <ccross@android.com>, <keescook@chromium.org>,
<tony.luck@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <long.wanglong@huawei.com>,
<peifeiyue@huawei.com>, <marco.stornelli@gmail.com>,
<anton.vorontsov@linaro.org>, <salyzyn@android.com>,
<sergiu@chromium.org>
Subject: [PATCH] fs/pstore: Optimization function ramoops_init_przs
Date: Tue, 17 Mar 2015 09:31:24 +0000 [thread overview]
Message-ID: <1426584684-187152-1-git-send-email-long.wanglong@huawei.com> (raw)
The value of cxt->record_size does not change in the loop,
so this patch optimize the assign statement by moving
it to outer.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
fs/pstore/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 44a549b..2105a16 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -373,6 +373,7 @@ static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
{
int err = -ENOMEM;
int i;
+ size_t sz;
if (!cxt->record_size)
return 0;
@@ -393,9 +394,8 @@ static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
goto fail_prz;
}
+ sz = cxt->record_size;
for (i = 0; i < cxt->max_dump_cnt; i++) {
- size_t sz = cxt->record_size;
-
cxt->przs[i] = persistent_ram_new(*paddr, sz, 0,
&cxt->ecc_info,
cxt->memtype);
--
1.8.3.4
next reply other threads:[~2015-03-17 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 9:31 Wang Long [this message]
2015-03-17 17:39 ` Kees Cook
2015-03-18 1:34 ` long.wanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426584684-187152-1-git-send-email-long.wanglong@huawei.com \
--to=long.wanglong@huawei.com \
--cc=anton.vorontsov@linaro.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=peifeiyue@huawei.com \
--cc=salyzyn@android.com \
--cc=sergiu@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®