From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965059AbbCQJwq (ORCPT ); Tue, 17 Mar 2015 05:52:46 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56753 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753711AbbCQJwk (ORCPT ); Tue, 17 Mar 2015 05:52:40 -0400 Message-ID: <1426585957.3709.0.camel@pengutronix.de> Subject: Re: [PATCH 27/35 linux-next] reset: sti: constify of_device_id array From: Philipp Zabel To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , linux-arm-kernel@lists.infradead.org, kernel@stlinux.com Date: Tue, 17 Mar 2015 10:52:37 +0100 In-Reply-To: <1426535685-25996-6-git-send-email-fabf@skynet.be> References: <1426533469-25458-1-git-send-email-fabf@skynet.be> <1426535685-25996-1-git-send-email-fabf@skynet.be> <1426535685-25996-6-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabian, Am Montag, den 16.03.2015, 20:54 +0100 schrieb Fabian Frederick: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > > Signed-off-by: Fabian Frederick > --- > drivers/reset/sti/reset-stih407.c | 2 +- > drivers/reset/sti/reset-stih415.c | 2 +- > drivers/reset/sti/reset-stih416.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/reset/sti/reset-stih407.c b/drivers/reset/sti/reset-stih407.c > index d83db5d7..e250604 100644 > --- a/drivers/reset/sti/reset-stih407.c > +++ b/drivers/reset/sti/reset-stih407.c > @@ -126,7 +126,7 @@ static const struct syscfg_reset_controller_data stih407_picophyreset_controller > .channels = stih407_picophyresets, > }; > > -static struct of_device_id stih407_reset_match[] = { > +static const struct of_device_id stih407_reset_match[] = { > { > .compatible = "st,stih407-powerdown", > .data = &stih407_powerdown_controller, > diff --git a/drivers/reset/sti/reset-stih415.c b/drivers/reset/sti/reset-stih415.c > index 8dad603..fd84238 100644 > --- a/drivers/reset/sti/reset-stih415.c > +++ b/drivers/reset/sti/reset-stih415.c > @@ -89,7 +89,7 @@ static struct syscfg_reset_controller_data stih415_softreset_controller = { > .channels = stih415_softresets, > }; > > -static struct of_device_id stih415_reset_match[] = { > +static const struct of_device_id stih415_reset_match[] = { > { .compatible = "st,stih415-powerdown", > .data = &stih415_powerdown_controller, }, > { .compatible = "st,stih415-softreset", > diff --git a/drivers/reset/sti/reset-stih416.c b/drivers/reset/sti/reset-stih416.c > index 79aed70..c7ccaed 100644 > --- a/drivers/reset/sti/reset-stih416.c > +++ b/drivers/reset/sti/reset-stih416.c > @@ -120,7 +120,7 @@ static struct syscfg_reset_controller_data stih416_softreset_controller = { > .channels = stih416_softresets, > }; > > -static struct of_device_id stih416_reset_match[] = { > +static const struct of_device_id stih416_reset_match[] = { > { .compatible = "st,stih416-powerdown", > .data = &stih416_powerdown_controller, }, > { .compatible = "st,stih416-softreset", Applied, thanks! regards Philipp