From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbbCQPiB (ORCPT ); Tue, 17 Mar 2015 11:38:01 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:15749 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461AbbCQPh7 (ORCPT ); Tue, 17 Mar 2015 11:37:59 -0400 From: Nicolas Ferre To: Andrew Morton CC: , , , , , , Boris BREZILLON , Alexandre Belloni , Jean-Christophe PLAGNIOL-VILLARD , Nicolas Ferre Subject: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt() Date: Tue, 17 Mar 2015 16:38:10 +0100 Message-ID: <1426606690-18947-1-git-send-email-nicolas.ferre@atmel.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <20150315104837.GC20691@mwanda> References: <20150315104837.GC20691@mwanda> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter There is a typo here so we deadlock. Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling') Signed-off-by: Dan Carpenter Acked-by: Boris Brezillon Reported-also-by: David Dueck Signed-off-by: Nicolas Ferre --- Hi Andrew, Can you please take care of this fix for 4.0? If you fee that I'd better take it myself please tell me. Thanks, bye. drivers/rtc/rtc-at91rm9200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index b4f7744f6751..b283a1a573b3 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id) ret = IRQ_HANDLED; } - spin_lock(&suspended_lock); + spin_unlock(&suspended_lock); return ret; } -- 2.1.3