From: Wang Long <long.wanglong@huawei.com>
To: <keescook@chromium.org>, <anton@enomsg.org>, <ccross@android.com>,
<tony.luck@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <long.wanglong@huawei.com>,
<peifeiyue@huawei.com>, <marco.stornelli@gmail.com>,
<anton.vorontsov@linaro.org>, <salyzyn@android.com>,
<sergiu@chromium.org>
Subject: [PATCH v2] fs/pstore: Optimization function ramoops_init_przs
Date: Wed, 18 Mar 2015 01:41:07 +0000 [thread overview]
Message-ID: <1426642867-194916-1-git-send-email-long.wanglong@huawei.com> (raw)
The value of cxt->record_size does not change in the loop,
so this patch optimize the assign statement by dropping
sz entirely and using cxt->record_size in its place.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
fs/pstore/ram.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 44a549b..f29373d 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -394,18 +394,16 @@ static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
}
for (i = 0; i < cxt->max_dump_cnt; i++) {
- size_t sz = cxt->record_size;
-
- cxt->przs[i] = persistent_ram_new(*paddr, sz, 0,
+ cxt->przs[i] = persistent_ram_new(*paddr, cxt->record_size, 0,
&cxt->ecc_info,
cxt->memtype);
if (IS_ERR(cxt->przs[i])) {
err = PTR_ERR(cxt->przs[i]);
dev_err(dev, "failed to request mem region (0x%zx@0x%llx): %d\n",
- sz, (unsigned long long)*paddr, err);
+ cxt->record_size, (unsigned long long)*paddr, err);
goto fail_prz;
}
- *paddr += sz;
+ *paddr += cxt->record_size;
}
return 0;
--
1.8.3.4
next reply other threads:[~2015-03-18 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 1:41 Wang Long [this message]
2015-03-18 20:11 ` Kees Cook
2015-05-04 9:30 ` long.wanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426642867-194916-1-git-send-email-long.wanglong@huawei.com \
--to=long.wanglong@huawei.com \
--cc=anton.vorontsov@linaro.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=peifeiyue@huawei.com \
--cc=salyzyn@android.com \
--cc=sergiu@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®