From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755667AbbCRJJb (ORCPT ); Wed, 18 Mar 2015 05:09:31 -0400 Received: from numascale.com ([213.162.240.84]:54200 "EHLO numascale.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753598AbbCRJJ2 (ORCPT ); Wed, 18 Mar 2015 05:09:28 -0400 Date: Wed, 18 Mar 2015 17:09:12 +0800 From: Daniel J Blueman Subject: Re: [PATCH] x86: Unbreak early processor microcode loading To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Quentin Casasnovas , Steffen Persvold , linux-kernel@vger.kernel.org, x86@kernel.org Message-Id: <1426669752.20093.1@cpanel21.proisp.no> In-Reply-To: <20150304114526.GE3516@pd.tnic> References: <20150304114526.GE3516@pd.tnic> X-Mailer: geary/0.8.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel21.proisp.no X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - numascale.com X-Get-Message-Sender-Via: cpanel21.proisp.no: authenticated_id: daniel@numascale.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 4, 2015 at 7:45 PM, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 10:18:47AM +0100, Borislav Petkov wrote: >> Let me try to reproduce that here. > > Well, it works fine on a single-socket box here: > > [ 1.045426] microcode: updated early to new patch_level=0x010000dc > [ 1.060957] microcode: CPU0: patch_level=0x010000dc > [ 1.061143] microcode: CPU1: patch_level=0x010000dc > [ 1.061310] microcode: CPU2: patch_level=0x010000dc > [ 1.061495] microcode: CPU3: patch_level=0x010000dc > [ 1.061677] microcode: CPU4: patch_level=0x010000dc > [ 1.061863] microcode: CPU5: patch_level=0x010000dc > > That's early patching. > > $ grep -E "(FIRMWARE|MICROCODE)" .config > CONFIG_MICROCODE=y > CONFIG_MICROCODE_INTEL=y > CONFIG_MICROCODE_AMD=y > CONFIG_MICROCODE_OLD_INTERFACE=y > CONFIG_MICROCODE_INTEL_EARLY=y > CONFIG_MICROCODE_AMD_EARLY=y > CONFIG_MICROCODE_EARLY=y > CONFIG_PREVENT_FIRMWARE_BUILD=y > CONFIG_FIRMWARE_IN_KERNEL=y > CONFIG_EXTRA_FIRMWARE="microcode_amd.bin microcode_amd_fam15h.bin > microcode_amd_fam16h.bin" > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware/amd-ucode" > # CONFIG_DRM_LOAD_EDID_FIRMWARE is not set > CONFIG_FIRMWARE_EDID=y > CONFIG_FIRMWARE_MEMMAP=y > # CONFIG_GOOGLE_FIRMWARE is not set > # CONFIG_TEST_FIRMWARE is not set Thanks for checking Boris! I can't reproduce your early-loading case with this same config; I suspect your udev is loading the firmware which is available in the initramfs, or it's being loaded later from the rootfs non-early. In my case, the microcode is in neither, hence we build it into the kernel image. The full console log, config and bzImage are at https://resources.numascale.com/telemetry/ I find the changes I posted earlier fix this. Maybe I'm missing something still? Daniel