From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755997AbbCRLNf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 07:13:35 -0400
Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:51064 "EHLO
	cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755911AbbCRLNd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 07:13:33 -0400
Message-ID: <1426677211.15575.27.camel@x220>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY
From: Paul Bolle <pebolle@tiscali.nl>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
        Bin Liu <binmlist@gmail.com>, Brian Hutchinson <b.hutchman@gmail.com>,
        Felipe Balbi <balbi@ti.com>,
        Matthijs van Duin <matthijsvanduin@gmail.com>,
        Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 18 Mar 2015 12:13:31 +0100
In-Reply-To: <1426637554-27178-1-git-send-email-tony@atomide.com>
References: <1426637554-27178-1-git-send-email-tony@atomide.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 18 Mar 2015 11:13:31.0679 (UTC) FILETIME=[915B5AF0:01D0616C]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Two trivialities I failed the spot the first time.

On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 2962de2..c858c2b 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig

> +config PHY_DM816X_USB
> +	tristate "TI dm816x USB PHY driver"
> +	depends on ARCH_OMAP2PLUS
> +	select GENERIC_PHY
> +	help
> +	  Enable this for dm81xx USB to work."
> +

A trailing double quote.

> --- /dev/null
> +++ b/drivers/phy/phy-dm816x-usb.c

> +MODULE_ALIAS("platform: dm816x_usb");

That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
will it end up in the mdule, in modules.alias, and presumably break
something (I'm not sure what, actually)?

There are currently six other instances MODULE_ALIAS() that have a space
there. That would mean they're all broken, somehow, which would be
unlikely, so I guess it's just a stylistic nit.


Paul Bolle