From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756290AbbCSAFU (ORCPT ); Wed, 18 Mar 2015 20:05:20 -0400 Received: from ozlabs.org ([103.22.144.67]:33171 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbbCSAFQ (ORCPT ); Wed, 18 Mar 2015 20:05:16 -0400 Message-ID: <1426723515.14101.2.camel@ellerman.id.au> Subject: Re: [PATCH v2] selftests: Fix build failures when invoked from kselftest target From: Michael Ellerman To: Shuah Khan Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 19 Mar 2015 11:05:15 +1100 In-Reply-To: <1426701942-25217-1-git-send-email-shuahkh@osg.samsung.com> References: <1426701942-25217-1-git-send-email-shuahkh@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-18 at 12:05 -0600, Shuah Khan wrote: > Several tests that rely on implicit build rules fail to build, > when invoked from the main Makefile kselftest target. These > failures are due to --no-builtin-rules and --no-builtin-variables > options set in the inherited MAKEFLAGS. > > --no-builtin-rules eliminates the use of built-in implicit rules > and --no-builtin-variables is for not defining built-in variables. > These two options override the use of implicit rules resulting in > build failures. In addition, inherited LDFLAGS result in build > failures and there is no need to define LDFLAGS. Clear LDFLAGS > and MAKEFLAG when make is invoked from the main Makefile kselftest > target. Fixing this at selftests Makefile avoids changing the main > Makefile and keeps this change self contained at selftests level. Yep this looks good. Acked-by: Michael Ellerman cheers