mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	konrad.wilk@oracle.com, david.vrabel@citrix.com,
	boris.ostrovsky@oracle.com, daniel.kiper@oracle.com
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid
Date: Thu, 19 Mar 2015 15:31:02 +0100	[thread overview]
Message-ID: <1426775462-981-3-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1426775462-981-1-git-send-email-jgross@suse.com>

Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set
regions above the end of RAM as 1:1") introduced a regression.

To be able to add memory pages which were added via memory hotplug to
a pv domain, the pages must be "invalid" instead of "identity" in the
p2m list before they can be added.

Suggested-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 0b52d92..52e331f 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -221,15 +221,24 @@ static bool balloon_is_inflated(void)
 
 static enum bp_state reserve_additional_memory(long credit)
 {
-	int nid, rc;
+	int nid, rc = 0;
 	u64 hotplug_start_paddr;
 	unsigned long balloon_hotplug = credit;
+	unsigned long pfn;
 
 	hotplug_start_paddr = PFN_PHYS(SECTION_ALIGN_UP(max_pfn));
 	balloon_hotplug = round_up(balloon_hotplug, PAGES_PER_SECTION);
 	nid = memory_add_physaddr_to_nid(hotplug_start_paddr);
 
-	rc = add_memory(nid, hotplug_start_paddr, balloon_hotplug << PAGE_SHIFT);
+	for (pfn = PFN_DOWN(hotplug_start_paddr);
+	     !rc && pfn < PFN_DOWN(hotplug_start_paddr) + balloon_hotplug;
+	     pfn++)
+		if (!set_phys_to_machine(pfn, INVALID_P2M_ENTRY))
+			rc = 1;
+
+	if (!rc)
+		rc = add_memory(nid, hotplug_start_paddr,
+				balloon_hotplug << PAGE_SHIFT);
 
 	if (rc) {
 		pr_warn("Cannot add additional memory (%i)\n", rc);
-- 
2.1.4


  parent reply	other threads:[~2015-03-19 14:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 14:31 [PATCH 0/2] xen: fix regressions regarding memory hotplug in pv domains Juergen Gross
2015-03-19 14:31 ` [PATCH 1/2] xen: prepare p2m list for memory hotplug Juergen Gross
2015-03-19 15:53   ` Boris Ostrovsky
2015-03-19 17:01     ` Juergen Gross
2015-03-19 16:14   ` Daniel Kiper
2015-03-19 17:05     ` Juergen Gross
2015-03-19 16:18   ` [Xen-devel] " David Vrabel
2015-03-19 17:16     ` Juergen Gross
2015-03-19 17:22       ` David Vrabel
2015-03-19 19:15   ` Paul Bolle
2015-03-19 14:31 ` Juergen Gross [this message]
2015-03-19 16:18   ` [Xen-devel] [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid David Vrabel
2015-03-19 17:19     ` Juergen Gross
2015-03-19 17:40       ` David Vrabel
2015-03-19 16:21   ` Daniel Kiper
2015-03-19 17:22     ` Juergen Gross
2015-03-19 18:40       ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426775462-981-3-git-send-email-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome