From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751286AbbCSTPL (ORCPT ); Thu, 19 Mar 2015 15:15:11 -0400 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:60053 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbbCSTPH (ORCPT ); Thu, 19 Mar 2015 15:15:07 -0400 Message-ID: <1426792505.23529.10.camel@x220> Subject: Re: [PATCH 1/2] xen: prepare p2m list for memory hotplug From: Paul Bolle To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com, daniel.kiper@oracle.com Date: Thu, 19 Mar 2015 20:15:05 +0100 In-Reply-To: <1426775462-981-2-git-send-email-jgross@suse.com> References: <1426775462-981-1-git-send-email-jgross@suse.com> <1426775462-981-2-git-send-email-jgross@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Mar 2015 19:15:05.0936 (UTC) FILETIME=[0216D500:01D06279] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-19 at 15:31 +0100, Juergen Gross wrote: > --- a/arch/x86/xen/p2m.c > +++ b/arch/x86/xen/p2m.c > +#ifdef CONFIG_X86_32 > +BUILD_BUG_ON_MSG(CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT > 64) > +#endif I assume BUILD_BUG_ON_MSG() aborts the build. > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > +config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT > + int > + default 512 if X86_64 > + default 4 if X86_32 > + depends on XEN_HAVE_PVMMU > + depends on XEN_BALLOON_MEMORY_HOTPLUG > + help > + Upper limit in GBs a pv domain can be expanded to using memory > + hotplug. > + > + This value is used to allocate enough space in internal tables needed > + for physical memory administration. > + I think adding a range 1 64 if X86_32 would allow to drop the BUILD_BUG_ON_MSG(). (I haven't tested this so you're allowed to bark at me if this ends up wasting your time.) Paul Bolle