From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbbCSVAc (ORCPT ); Thu, 19 Mar 2015 17:00:32 -0400 Received: from mailgw02.mediatek.com ([69.46.227.142]:42296 "EHLO mailgw02.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbbCSVAa (ORCPT ); Thu, 19 Mar 2015 17:00:30 -0400 X-Listener-Flag: 11101 Message-ID: <1426798523.27166.3.camel@mussux00.eus.mediatek.inc> Subject: Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array From: Hongzhou Yang To: Fabian Frederick CC: Linus Walleij , Lee Jones , Maxime Coquelin , Jean-Christophe Plagniol-Villard , Matthias Brugger , , Srinivas Kandagatla , , , Axel Lin , "Greg Kroah-Hartman" , , , , Maxime Ripard , Stephen Warren , Patrice Chotard , Date: Thu, 19 Mar 2015 13:55:23 -0700 In-Reply-To: <1144194766.100372.1426790475037.open-xchange@webmail.nmp.proximus.be> References: <1426533469-25458-1-git-send-email-fabf@skynet.be> <1426535949-26107-1-git-send-email-fabf@skynet.be> <1426535949-26107-4-git-send-email-fabf@skynet.be> <1426730289.21744.7.camel@mussux00.eus.mediatek.inc> <1144194766.100372.1426790475037.open-xchange@webmail.nmp.proximus.be> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-19 at 19:41 +0100, Fabian Frederick wrote: > > > On 19 March 2015 at 02:58 Hongzhou Yang wrote: > > > > > > On Mon, 2015-03-16 at 20:59 +0100, Fabian Frederick wrote: > > > of_device_id is always used as const. > > > (See driver.of_match_table and open firmware functions) > > > > > > Signed-off-by: Fabian Frederick > > > --- > > > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +- > > > drivers/pinctrl/mediatek/pinctrl-mt8135.c | 2 +- > > > drivers/pinctrl/mediatek/pinctrl-mt8173.c | 2 +- > > > > > > > For the pinctrl-mt81xx driver, > > Acked-by: Hongzhou Yang > > > > By the way, Axel has sent same patch to linux-gpio. > > http://article.gmane.org/gmane.linux.kernel.gpio/6815 > > > > Thanks. > > Hongzhou > > > Axel's version is better (it also improves display) but doesn't > include bcm. I'll resend if necessary. > > Regards, > Fabian Hi Fabian, Sorry, it's my fault. Our patch only include pinctrl-mt8135.c and pinctrl-mt8173.c, bcm is not ours. Thank you. Yours, Hongzhou