From: Taesoo Kim <tsgatesv@gmail.com>
To: jaegeuk@kernel.org, cm224.lee@samsung.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu,
blee@gatech.edu, csong84@gatech.edu,
Taesoo Kim <tsgatesv@gmail.com>
Subject: [PATCH 1/1] f2fs: correctly check empty xattr key
Date: Fri, 20 Mar 2015 00:19:07 -0400 [thread overview]
Message-ID: <1426825147-26981-1-git-send-email-tsgatesv@gmail.com> (raw)
When xattr name (key) is empty (""), correctly return -EINVAL
error. xattr_advise_set/get() seem to make the same mistake.
Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
---
fs/f2fs/xattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index 5072bf9..6b1fbc4 100644
--- a/fs/f2fs/xattr.c
+++ b/fs/f2fs/xattr.c
@@ -132,7 +132,7 @@ static int f2fs_xattr_advise_get(struct dentry *dentry, const char *name,
{
struct inode *inode = dentry->d_inode;
- if (strcmp(name, "") != 0)
+ if (strcmp(name, "") == 0)
return -EINVAL;
*((char *)buffer) = F2FS_I(inode)->i_advise;
@@ -144,7 +144,7 @@ static int f2fs_xattr_advise_set(struct dentry *dentry, const char *name,
{
struct inode *inode = dentry->d_inode;
- if (strcmp(name, "") != 0)
+ if (strcmp(name, "") == 0)
return -EINVAL;
if (!inode_owner_or_capable(inode))
return -EPERM;
--
2.3.3
next reply other threads:[~2015-03-20 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 4:19 Taesoo Kim [this message]
2015-03-20 20:52 ` Jaegeuk Kim
2015-03-23 1:13 ` Taesoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426825147-26981-1-git-send-email-tsgatesv@gmail.com \
--to=tsgatesv@gmail.com \
--cc=blee@gatech.edu \
--cc=changwoo@gatech.edu \
--cc=cm224.lee@samsung.com \
--cc=csong84@gatech.edu \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sanidhya@gatech.edu \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome