From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751047AbbCTEYC (ORCPT ); Fri, 20 Mar 2015 00:24:02 -0400 Received: from ozlabs.org ([103.22.144.67]:37168 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbCTEX7 (ORCPT ); Fri, 20 Mar 2015 00:23:59 -0400 Message-ID: <1426825436.2581.1.camel@ellerman.id.au> Subject: Re: [PATCH v3 0/4] powerpc: trivial unused functions cleanup From: Michael Ellerman To: Arseny Solokha Cc: Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 20 Mar 2015 15:23:56 +1100 In-Reply-To: <1426823789-949-1-git-send-email-asolokha@kb.kras.ru> References: <1424768706-23150-1-git-send-email-asolokha@kb.kras.ru> <1426823789-949-1-git-send-email-asolokha@kb.kras.ru> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-20 at 10:56 +0700, Arseny Solokha wrote: > This series removes unused functions from powerpc tree that I've been able > to discover. > > Two machines at hands, e300 and e500 based, boot and run without regressions > on my workload with this series applied. The removed code seems also been > rarely touched, so it seems the series is safe at least in general. But I > can't obviously express any strong point in support of the series, so it's > completely OK to leave things as is. > > v3: In patch 4/4, do not remove fsl_mpic_primary_get_version() from > arch/powerpc/sysdev/mpic.c because the patch by Jia Hongtao > ("powerpc/85xx: workaround for chips with MSI hardware errata") makes > use of it. Sorry, too late. https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=5e86bfde9cd93f272844c3ff6ac5f93d3666b3e7 The patch that needs it can just add it back. cheers