mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	konrad.wilk@oracle.com, david.vrabel@citrix.com,
	boris.ostrovsky@oracle.com, daniel.kiper@oracle.com,
	pebolle@tiscali.nl
Cc: Juergen Gross <jgross@suse.com>
Subject: [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid
Date: Fri, 20 Mar 2015 13:55:39 +0100	[thread overview]
Message-ID: <1426856139-3359-3-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1426856139-3359-1-git-send-email-jgross@suse.com>

Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set
regions above the end of RAM as 1:1") introduced a regression.

To be able to add memory pages which were added via memory hotplug to
a pv domain, the pages must be "invalid" instead of "identity" in the
p2m list before they can be added.

Suggested-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 0b52d92..65fedb8 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -229,6 +229,19 @@ static enum bp_state reserve_additional_memory(long credit)
 	balloon_hotplug = round_up(balloon_hotplug, PAGES_PER_SECTION);
 	nid = memory_add_physaddr_to_nid(hotplug_start_paddr);
 
+#ifdef CONFIG_XEN_HAVE_PVMMU
+	if (!xen_feature(XENFEAT_auto_translated_physmap)) {
+		unsigned long pfn, i;
+
+		pfn = PFN_DOWN(hotplug_start_paddr);
+		for (i = 0; i < balloon_hotplug; i++)
+			if (!set_phys_to_machine(pfn + i, INVALID_P2M_ENTRY)) {
+				pr_warn("set_phys_to_machine() failed, no memory added\n");
+				return BP_ECANCELED;
+			}
+	}
+#endif
+
 	rc = add_memory(nid, hotplug_start_paddr, balloon_hotplug << PAGE_SHIFT);
 
 	if (rc) {
-- 
2.1.4


  parent reply	other threads:[~2015-03-20 12:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 12:55 [Patch V2 0/2] xen: fix regressions regarding memory hotplug in pv domains Juergen Gross
2015-03-20 12:55 ` [Patch V2 1/2] xen: prepare p2m list for memory hotplug Juergen Gross
2015-03-20 13:42   ` Daniel Kiper
2015-03-23 12:46   ` [Xen-devel] " David Vrabel
2015-03-23 14:29     ` Juergen Gross
2015-03-23 14:57       ` David Vrabel
2015-03-20 12:55 ` Juergen Gross [this message]
2015-03-20 13:44   ` [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid Boris Ostrovsky
2015-03-20 14:35     ` Juergen Gross
2015-03-23 11:47     ` [Xen-devel] " David Vrabel
2015-03-20 13:46   ` Daniel Kiper
2015-03-20 14:27     ` Juergen Gross
2015-03-23 11:59     ` David Vrabel
2015-03-23 15:17 ` [Xen-devel] [Patch V2 0/2] xen: fix regressions regarding memory hotplug in pv domains David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426856139-3359-3-git-send-email-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®