From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbbCTQO5 (ORCPT ); Fri, 20 Mar 2015 12:14:57 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:42195 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbbCTQOy (ORCPT ); Fri, 20 Mar 2015 12:14:54 -0400 Message-ID: <1426868089.14974.12.camel@mm-sol.com> Subject: Re: [PATCH v2] spi: Ensure that CS line is in non-active state after spi_setup() From: "Ivan T. Ivanov" To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Fri, 20 Mar 2015 18:14:49 +0200 In-Reply-To: <1426265029-12280-1-git-send-email-iivanov@mm-sol.com> References: <1426265029-12280-1-git-send-email-iivanov@mm-sol.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-13 at 18:43 +0200, Ivan T. Ivanov wrote: > Some devices samples state of the chip select signal during power up > and act differently based on this state, so SPI core should ensure > that CS line is driven in non-active state after spi_setup(). > > Signed-off-by: Ivan T. Ivanov > --- Any comments on this one? Forget to add changes since v1 [1]. CS is set to non-active state unconditionally before spi->master->setup() Regards, Ivan [1] http://www.spinics.net/lists/linux-spi/msg03056.html > drivers/spi/spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index c64a3e5..4023cc9 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1893,6 +1893,8 @@ int spi_setup(struct spi_device *spi) > if (!spi->max_speed_hz) > spi->max_speed_hz = spi->master->max_speed_hz; > > + spi_set_cs(spi, false); > + > if (spi->master->setup) > status = spi->master->setup(spi); >