From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbbCTVrd (ORCPT ); Fri, 20 Mar 2015 17:47:33 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:34586 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbbCTVrc (ORCPT ); Fri, 20 Mar 2015 17:47:32 -0400 From: Taesoo Kim To: dushistov@mail.ru, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu, Taesoo Kim Subject: [PATCH 1/1] ufs: return correct errno for write_inode() Date: Fri, 20 Mar 2015 17:47:24 -0400 Message-Id: <1426888044-30479-1-git-send-email-tsgatesv@gmail.com> X-Mailer: git-send-email 2.3.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of -1, properly return -EIO upon write_inode() error, similar/consistant to the rest of filesystems. Signed-off-by: Taesoo Kim --- fs/ufs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index be7d42c..9f910d8 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c @@ -836,13 +836,13 @@ static int ufs_update_inode(struct inode * inode, int do_sync) if (inode->i_ino < UFS_ROOTINO || inode->i_ino > (uspi->s_ncg * uspi->s_ipg)) { ufs_warning (sb, "ufs_read_inode", "bad inode number (%lu)\n", inode->i_ino); - return -1; + return -EIO; } bh = sb_bread(sb, ufs_inotofsba(inode->i_ino)); if (!bh) { ufs_warning (sb, "ufs_read_inode", "unable to read inode %lu\n", inode->i_ino); - return -1; + return -EIO; } if (uspi->fs_magic == UFS2_MAGIC) { struct ufs2_inode *ufs2_inode = (struct ufs2_inode *)bh->b_data; -- 2.3.3