From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbbCVAA2 (ORCPT ); Sat, 21 Mar 2015 20:00:28 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:44047 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbbCVAAY (ORCPT ); Sat, 21 Mar 2015 20:00:24 -0400 From: Stefan Agner To: tony@atomide.com Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvmlinux@lists.linuxfoundation.org, Stefan Agner Subject: [PATCH] arm: mach-omap2: remove superfluous NULL pointer check Date: Sun, 22 Mar 2015 01:00:18 +0100 Message-Id: <1426982418-9649-1-git-send-email-stefan@agner.ch> X-Mailer: git-send-email 2.3.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The NULL pointer check for superset->muxnames will always evaluate true since muxnames is an array within struct omap_mux. Remove the superfluous check to avoid warnings when using LLVM/clang. Signed-off-by: Stefan Agner --- For the reference, the warning generated by LLVM/clang: arch/arm/mach-omap2/mux.c:1056:18: warning: address of array 'superset->muxnames' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!superset->muxnames || !superset->muxnames[0]) { ~~~~~~~~~~~^~~~~~~~ arch/arm/mach-omap2/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 78064b0..176eef6 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -1053,7 +1053,7 @@ static void __init omap_mux_init_list(struct omap_mux_partition *partition, struct omap_mux *entry; #ifdef CONFIG_OMAP_MUX - if (!superset->muxnames || !superset->muxnames[0]) { + if (!superset->muxnames[0]) { superset++; continue; } -- 2.3.3